Making a pull request

Step-by-step

1. Does your bug fix or feature have a corresponding GitHub issue? If not, open one!
2. Is it a bug fix or a feature?
   • bug fix: goes into the latest release branch, e.g. release_v0.12.3.
   • feature: goes into the develop branch
3. Check out the correct branch locally:

    git checkout release_vX.Y.Z
    git pull origin release_vX.Y.Z

4. Create a new issue branch using the following naming convention:

    git checkout -b issue_1234_short_description_of_issue

5. Add your changes and commit them to your issue branch.
   • If it's a bug, add a test
   • If it's a new feature, add tests
6. When you're ready, push your local branch to your fork

    git push fork issue_1234_short_description_of_issue

7. Create a pull request on GitHub from the branch in your fork to the correct branch of aiidateam/aiida_core
   • Use the PR title to describe its contents (bad: "Fix issue 1234", good: "quicksetup now works without sudo")
   • Mention the issue number in the description of the PR

Etiquette

• Open your pull request only once you believe your changes are ready to be merged.
  If you keep pushing changes to an open PR, developers are flooded with emails.
• All PRs undergo continuous integration testing using Travis. If your PR fails a test (no worries), you are expected to fix them before a developer reviews your PR.