yapf doesn't indent long line

[szoupanos]

For example have a look a the following commit and failing test.

szoupanos/aiida_core@ad24a32...6159f50
https://travis-ci.org/szoupanos/aiida_core/jobs/446050100

yapf doesn't correct the long line (and it should) and prospector fails (and from the discussion that I had with @ltalirz, indentation and code formatting is the job of yapf and not of prospector).

[dev-zero]

can reproduce, but I guess there is not much we can do about it.

The line in question could be rewritten as follows instead:

_CREATE_DB_COMMAND = (
    'CREATE DATABASE "{}" OWNER "{}"'
    "ENCODING 'UTF8' LC_COLLATE='en_US.UTF-8' LC_CTYPE='en_US.UTF-8' TEMPLATE=template0")

[ltalirz]

@dev-zero Do we understand why, though?

[dev-zero]

@ltalirz yapf does not split strings by itself, most likely because the position to sensibly split a string depends on the content of the string, but there is an open feature request: google/yapf#408

[ltalirz]

Thanks! We can keep this open, periodically checking the progress in yapf.

[giovannipizzi]

I'm closing this, as there is not much we can do, except telling developers what to do.
For this, yesterday I added a guide in the wiki on how to use the pre-commit hooks here. I've now added an explanation of what to do in this case, and a link to this issue.
When/if yapf fixes this and we upgrade its version, this will be solved automatically.