Skip to content

Daemon megachange#1067

Merged
sphuber merged 11 commits into
aiidateam:workflowsfrom
muhrin:daemon_megachange
Jan 19, 2018
Merged

Daemon megachange#1067
sphuber merged 11 commits into
aiidateam:workflowsfrom
muhrin:daemon_megachange

Conversation

@muhrin
Copy link
Copy Markdown
Contributor

@muhrin muhrin commented Jan 18, 2018

Sorry mixed a few things here:

  • verdi work commands
  • Ripping out 'old new' daemon
  • Changing ascii visualisation for status command
  • Adding blocking launch.submit() call

muhrin and others added 10 commits January 15, 2018 11:03
Problem is, this is inherently not supported in plum and cannot be
achieved using a runner because it does not give us a future.

Will require some more work.
The ASCII visualisation of trees and call graphs has now been
abstracted and placed in a util function.  The work command
calls through.
Got rid of 'old new' daemon code.

Changed play/pause/kill to not need a runner - doesn't make sense.  Now
these use the blocking control panel.
@muhrin muhrin requested a review from sphuber January 18, 2018 17:11
@sphuber
Copy link
Copy Markdown
Contributor

sphuber commented Jan 18, 2018

Tests are broken yo...
And any specific reason you deleted the eos examples? I mean they probably would have to be updated, but just out of curiosity

@sphuber sphuber merged commit 17278df into aiidateam:workflows Jan 19, 2018
@muhrin muhrin deleted the daemon_megachange branch February 20, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants