Port InlineCalculations to go through the Process layer#1124
Merged
sphuber merged 4 commits intoFeb 16, 2018
Conversation
Along the way discovered that default values were not checked in inline calculations for being Data types. This is now added. Found bug in workfunctions mechanism that was not using defaults correctly and therefore before this commit any default values in workfunctions were at risk of being wrong (by at risk I mean 100% wrong). Also discovered problem in plumpy when a default value was not passed. This was being passed as None and was therefore not being differentiated from an unspecified value when being validated.
The process state terminology CANCELLED/FAILED was changed to KILLED/EXCEPTED in a recent plumpy update
The process state terminology CANCELLED/FAILED was changed to KILLED/EXCEPTED in a recent plumpy update
…da_core into fix_1123_inline_calc_process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1123
Ported inline calculations to use workfunction mechanism
Along the way discovered that default values were not checked in inline
calculations for being Data types. This is now added.
Found bug in workfunctions mechanism that was not using defaults correctly
and therefore before this commit any default values in workfunctions were
at risk of being wrong (by at risk I mean 100% wrong).
Also discovered problem in plumpy when a default value was not passed. This
was being passed as None and was therefore not being differentiated from an
unspecified value when being validated.