Fix a bug in store method of CifData#1136
Merged
Merged
Conversation
The policy is that one can .store() on a node as many times as one wants. If the node is already stored it simply shouldn't do anything. This was not respected in the overriden store method of the CifData data class, that always tried to set the md5 attribute which would except when the node was already stored because then attributes are immutable
sphuber
force-pushed
the
fix_cif_data_store
branch
from
5587355 to
215133e
Compare
muhrin
approved these changes
Feb 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The policy is that one can
.store()on a node as many times as onewants. If the node is already stored it simply shouldn't do anything.
This was not respected in the overriden store method of the
CifDatadata class, that always tried to set the md5 attribute which would
except when the node was already stored because then attributes are
immutable