Improve the output of 'verdi calculation show'#1212
Merged
sphuber merged 1 commit intoMar 2, 2018
Conversation
With the addition of WorkCalculations came the new link types RETURN and CALL, however, the output of 'verdi calculation show' was still grouping all links in the categories OUTPUTS and INPUTS. Here we properly divide the linked nodes in four different groups: * Called by (Incoming CALL link, can only be one) * Inputs (Incoming INPUT links) * Outputs (Outgoing CREATE/RETURN links, take the unique set) * Called (Outgoing CALL links) Also reformatted the output a bit by adding new lines between the different groups to enhance readability
giovannipizzi
approved these changes
Mar 1, 2018
Member
giovannipizzi
left a comment
giovannipizzi
left a comment
There was a problem hiding this comment.
In general, I think we should find a good/better API for getting incoming/outgoing links, as the same issue exists elsewhere in the code. This anyway already solves a big problem, thanks!
Contributor
Author
|
Agreed, this would be part of the bigger work that needs to be done to fix link-type based code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #910
With the addition of
WorkCalculationscame the new link typesRETURNand
CALL, however, the output of 'verdi calculation show' was stillgrouping all links in the categories
OUTPUTSandINPUTS. Here weproperly divide the linked nodes in four different groups:
Also reformatted the output a bit by adding new lines between the
different groups to enhance readability