ZipFile: set allowZip64=True as the default.#1619
Merged
giovannipizzi merged 1 commit intoJun 4, 2018
Merged
Conversation
Solves the issue #1617
Codecov Report
@@ Coverage Diff @@
## release_v0.12.1 #1619 +/- ##
================================================
Coverage 54.68% 54.68%
================================================
Files 246 246
Lines 32419 32419
================================================
Hits 17729 17729
Misses 14690 14690
Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Jun 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the issue #1617 (exporting large databases)
According to my tests enabling the flag allowZip64=True does not change the time to create a zip archive. For more details see #1617