fix plugin test fixtures for unittest#1622
Merged
ltalirz merged 4 commits intoJun 5, 2018
Merged
Conversation
Member
ltalirz
commented
Jun 4, 2018
ltalirz
commented
- unittest fixtures now use a custom testrunner
- testrunner allows to run multiple testcases (fix plugin fixtures work only for a single test case #1425)
- testrunner will set up aiida environment only once per run (fix speed up plugin test fixtures #1451)
plugin fixtures can now be used in the unittest framework with more than one test (fix aiidateam#1425). Also, a test runner now allows to run multiple test cases without having to destroy and re-create the whole environment each time (fix aiidateam#1451).
Codecov Report
@@ Coverage Diff @@
## release_v0.12.1 #1622 +/- ##
==================================================
+ Coverage 54.68% 54.7% +0.01%
==================================================
Files 246 246
Lines 32419 32420 +1
==================================================
+ Hits 17729 17735 +6
+ Misses 14690 14685 -5
Continue to review full report at Codecov.
|
DropD
approved these changes
Jun 5, 2018
| cls.fixture_manager = _GLOBAL_FIXTURE_MANAGER | ||
| if not cls.fixture_manager.has_profile_open(): | ||
| raise ValueError( | ||
| "Fixture mananger has no open profile. Please use aiida.utils.fixtures.TestRunner to run these tests." |
This was referenced Jun 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.