Homogenize the interface of verdi quicksetup and verdi setup#1797
Merged
sphuber merged 1 commit intoJul 26, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1797 +/- ##
===========================================
+ Coverage 66.56% 66.59% +0.02%
===========================================
Files 314 314
Lines 32318 32333 +15
===========================================
+ Hits 21512 21531 +19
+ Misses 10806 10802 -4
Continue to review full report at Codecov.
|
These two commands should essentially provide the exact same interface to the user, as the only difference is that `verdi quicksetup` will try to guess most of the required variables to setup a profile. However, the functionality once all required variables are defined should be identical for the two commands. * Both commands now have the same options and arguments * All options and arguments are defined once as Overridable* * All options now have a help string
sphuber
force-pushed
the
fix_969_homogenize_verdi_setup_quicksetup
branch
from
c34b124 to
c05d2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969
These two commands should essentially provide the exact same interface
to the user, as the only difference is that
verdi quicksetupwilltry to guess most of the required variables to setup a profile.
However, the functionality once all required variables are defined
should be identical for the two commands.