Check for test_ keyword in repo path only on last directory#1812
Merged
sphuber merged 1 commit intoJul 30, 2018
Merged
Conversation
sphuber
force-pushed
the
fix_1482_improve_repository_path_check_test_profiles
branch
from
c62ffbc to
b3c7afb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1812 +/- ##
========================================
Coverage 66.58% 66.58%
========================================
Files 315 315
Lines 32368 32368
========================================
Hits 21553 21553
Misses 10815 10815
Continue to review full report at Codecov.
|
The `create_configuration` function would check the repository path for the `test_` keyword and would raise if it was absent for a test profile or present for a non-test profile. However, the check was performed on whether the prefix was present in the entire path. This is too strict, as this would disallow any path that even downstream would contain the string `test_`. Here, we change the test to just check the last directory of the absolute path, which was the intended behavior
sphuber
force-pushed
the
fix_1482_improve_repository_path_check_test_profiles
branch
from
b3c7afb to
1fe16e4
Compare
muhrin
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1482
The
create_configurationfunction would check the repository path for thetest_keyword and would raise if it was absent for a test profile or presentfor a non-test profile. However, the check was performed on whether the prefix
was present in the entire path. This is too strict, as this would disallow any
path that even downstream would contain the string
test_. Here, we changethe test to just check the last directory of the absolute path, which was the
intended behavior