Add verdi work show#1816
Merged
Merged
Conversation
sphuber
force-pushed
the
fix_1815_verdi_work_show
branch
2 times, most recently
from
12f10c1 to
d8e7759
Compare
In working on this issue, it was also found that the `verdi calculation` commands, no longer accepted `InlineCalculation` nodes but only calcs of the type `JobCalculation`. This was has been addressed as well. Finally, with the `verdi` click group being defined in the module init of `aiida.cmdline`, as well as all sub commands being imported, such that they are registered, the sub commands having to import the verdi group to attach themselves, caused a cyclic import. By moving the `verdi` group to its own file, this cyclicity is broken.
sphuber
force-pushed
the
fix_1815_verdi_work_show
branch
from
d8e7759 to
469df8e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1816 +/- ##
===========================================
+ Coverage 66.58% 66.64% +0.05%
===========================================
Files 315 317 +2
Lines 32368 32394 +26
===========================================
+ Hits 21553 21588 +35
+ Misses 10815 10806 -9
Continue to review full report at Codecov.
|
muhrin
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1815
In working on this issue, it was also found that the
verdi calculationcommands, no longer accepted
InlineCalculationnodes but only calcs ofthe type
JobCalculation. This was has been addressed as well.Finally, with the
verdiclick group being defined in the module initof
aiida.cmdline, as well as all sub commands being imported, such thatthey are registered, the sub commands having to import the verdi group
to attach themselves, caused a cyclic import. By moving the
verdigroup to its own file, this cyclicity is broken.