Synchronize heuristics of verdi work list and verdi calculation list#1819
Merged
sphuber merged 1 commit intoJul 31, 2018
Merged
Conversation
The logic for both these commands should be that for default values of all the options, all entries are shown that are considered 'active'. The `-a/--all` flag will cause all entries to be shown, independent of their 'activeness'. Finally, this list can be limited by passing the `-p/--past-days` flag. This issue was indirectly addressed by the move of `verdi` to the `click` infrastructure as now both commands use the same options, defined in `aiida.cmdline.params.option`. This commit just updates the help text of the `-a/--all` flag to make sure that it correctly reflects its behavior.
Codecov Report
@@ Coverage Diff @@
## develop #1819 +/- ##
===========================================
- Coverage 66.64% 66.61% -0.03%
===========================================
Files 317 317
Lines 32394 32394
===========================================
- Hits 21588 21579 -9
- Misses 10806 10815 +9
Continue to review full report at Codecov.
|
muhrin
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1804
The logic for both these commands should be that for default values of
all the options, all entries are shown that are considered 'active'.
The
-a/--allflag will cause all entries to be shown, independentof their 'activeness'. Finally, this list can be limited by passing the
-p/--past-daysflag. This issue was indirectly addressed by the moveof
verdito theclickinfrastructure as now both commands use thesame options, defined in
aiida.cmdline.params.option.This commit just updates the help text of the
-a/--allflag to makesure that it correctly reflects its behavior.