Ported job calculation to use coroutines for tasks#1827
Merged
Conversation
This way the event loop has a chance to schedule other operations while a transport request is made i.e. if multiple job calculations all request the same transport (a common scenario) then in the past they would all run as one loop callback effectively blocking the loop (and crucially pika heartbeats). Now they are schedule as seperate callbacks thanks to yield, hopefully, allowing the loop to schedule other necessary tasks in between.
Codecov Report
@@ Coverage Diff @@
## develop #1827 +/- ##
===========================================
+ Coverage 58.16% 66.68% +8.52%
===========================================
Files 317 317
Lines 32394 32409 +15
===========================================
+ Hits 18843 21613 +2770
+ Misses 13551 10796 -2755
Continue to review full report at Codecov.
|
sphuber
approved these changes
Jul 31, 2018
Contributor
sphuber
left a comment
There was a problem hiding this comment.
Merge transport request granted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1828
This way the event loop has a chance to schedule other operations while
a transport request is made i.e. if multiple job calculations all
request the same transport (a common scenario) then in the past they
would all run as one loop callback effectively blocking the loop (and
crucially pika heartbeats). Now they are schedule as seperate callbacks
thanks to yield, hopefully, allowing the loop to schedule other
necessary tasks in between.