Skip to content

Fix the formatting of verdi calculation logshow#1850

Merged
sphuber merged 1 commit into
aiidateam:developfrom
sphuber:fix_1849_verdi_calculation_logshow_new_lines
Aug 7, 2018
Merged

Fix the formatting of verdi calculation logshow#1850
sphuber merged 1 commit into
aiidateam:developfrom
sphuber:fix_1849_verdi_calculation_logshow_new_lines

Conversation

@sphuber
Copy link
Copy Markdown
Contributor

@sphuber sphuber commented Aug 7, 2018

Fixes #1849

The function aiida.cmdline.utils.common.get_calculation_log_report was
not properly formatting the multiline string with respect to the new
lines.`

The function `aiida.cmdline.utils.common.get_calculation_log_report` was
not properly formatting the multiline string with respect to the new
lines.`
@sphuber sphuber requested a review from muhrin August 7, 2018 12:19
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1850 into develop will decrease coverage by <.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1850      +/-   ##
===========================================
- Coverage    66.79%   66.79%   -0.01%     
===========================================
  Files          316      316              
  Lines        32313    32315       +2     
===========================================
+ Hits         21584    21585       +1     
- Misses       10729    10730       +1
Impacted Files Coverage Δ
aiida/cmdline/utils/common.py 55.62% <42.85%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5f518...47646f7. Read the comment docs.

Copy link
Copy Markdown
Contributor

@muhrin muhrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shiz gets better by the day

@sphuber sphuber merged commit 15fe8ad into aiidateam:develop Aug 7, 2018
@sphuber sphuber deleted the fix_1849_verdi_calculation_logshow_new_lines branch August 7, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants