Determine active nodes in verdi calculation list based on process state#1873
Merged
sphuber merged 1 commit intoAug 14, 2018
Conversation
The base behavior of `verdi calculation list`, just as its counterpart `verdi work list`, should be to list all the "active" entries. However, what constitutes an "active" entry for these two differs. For the work command, this is determined based on the process state of the nodes. Any node that is not in a terminal process state, is considered active. However, for legacy reasons, in `verdi calculation list` the activeness was still being based on the calculation state, which was not always in sync with the process state, leading to inconsistent displays. Here we update the behavior of `verdi calculation list` to determine the activeness of calculation nodes based on their process state, thus making it directly equivalent with the behavior of `verdi work list` and `verdi process list.
Codecov Report
@@ Coverage Diff @@
## develop #1873 +/- ##
===========================================
+ Coverage 61.38% 66.77% +5.38%
===========================================
Files 320 320
Lines 32549 32548 -1
===========================================
+ Hits 19981 21734 +1753
+ Misses 12568 10814 -1754
Continue to review full report at Codecov.
|
muhrin
approved these changes
Aug 14, 2018
Contributor
muhrin
left a comment
muhrin
left a comment
There was a problem hiding this comment.
I love it, especially in late summer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817
The base behavior of
verdi calculation list, just as its counterpartverdi work list, should be to list all the "active" entries. However,what constitutes an "active" entry for these two differs. For the work
command, this is determined based on the process state of the nodes.
Any node that is not in a terminal process state, is considered active.
However, for legacy reasons, in
verdi calculation listthe activenesswas still being based on the calculation state, which was not always in
sync with the process state, leading to inconsistent displays.
Here we update the behavior of
verdi calculation listto determine theactiveness of calculation nodes based on their process state, thus
making it directly equivalent with the behavior of
verdi work listand`verdi process list.