Implement verdi profile show#2028
Merged
Merged
Conversation
sphuber
force-pushed
the
fix_2027_verdi_profile_show
branch
from
71253fa to
d1a808b
Compare
giovannipizzi
approved these changes
Oct 5, 2018
Member
giovannipizzi
left a comment
giovannipizzi
left a comment
There was a problem hiding this comment.
Very useful!
BTW, in the docs, do we still have an hardcoded list of verdi commands/are we keeping it updated? Should we make the list auto-generated?
Contributor
Author
|
Yes it is still hardcoded. Now that we have fully migrated to click we can generate it procedurally. I already have some initial solution, but had to park it due to other priorities. I will finish it at some point |
sphuber
force-pushed
the
fix_2027_verdi_profile_show
branch
from
d1a808b to
c29702d
Compare
This command will show the settings for a given profile, or the default profile if no profile is specified. To facilitate this a new click parameter type `ProfileParamType` is defined, which provides automatic validation as well as auto complete support.
sphuber
force-pushed
the
fix_2027_verdi_profile_show
branch
from
c29702d to
4c68fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2027
This command will show the settings for a given profile, or the
default profile if no profile is specified. To facilitate this
a new click parameter type
ProfileParamTypeis defined, whichprovides automatic validation as well as auto complete support.