Set default polling interval for Runners to 1 second#2160
Merged
sphuber merged 1 commit intoNov 7, 2018
Conversation
In a recent change this parameter was corrected from 0 to 30 seconds to prevent the daemon workers from spinning the processors too much, but this really slows down the tests. Until resources like runners and communicators are created in a central place, that allows settings to be determined based on the active profile, e.g. with special settings for test profiles, we need to revert this to 1 second. This will allow the tests to run reasonably fast, without overloading processors too much.
muhrin
approved these changes
Nov 7, 2018
Member
|
0.1s would be already too low? |
Contributor
Author
|
That is something we would have to determine empirically. Zero is definitely not a good idea for production environments if you value your procs. In any case, this PR is more to restore normal test running times (they were taking 30 mins with 30. second as a setting). We are working on a PR with martin to make these things centrally controlled and automatically set for testing profiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent change this parameter was corrected from 0 to 30 seconds to
prevent the daemon workers from spinning the processors too much, but
this really slows down the tests. Until resources like runners and
communicators are created in a central place, that allows settings to be
determined based on the active profile, e.g. with special settings for
test profiles, we need to revert this to 1 second. This will allow the
tests to run reasonably fast, without overloading processors too much.