Compile the scripts before calling exec in verdi run#2166
Merged
Conversation
This extra step is necessary for python modules like `inspect` to function normally. Without this change, running a script with `verdi run` that defines a workfunction and then runs it would fail, because inspect would fail to determine the path of the source file of the workfunction, i.e. the script that was passed to `verdi run`. This change fixes that.
giovannipizzi
approved these changes
Nov 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2165
This extra step is necessary for python modules like
inspecttofunction normally. Without this change, running a script with
verdi runthat defines a workfunction and then runs it would fail, because inspect
would fail to determine the path of the source file of the workfunction,
i.e. the script that was passed to
verdi run. This change fixes that.