Fix bug in parse_formula for formula's with leading or trailing whitespace#2186
Merged
sphuber merged 1 commit intoNov 11, 2018
Merged
Conversation
…tespace If a formula contains leading or trailing whitespace, one of the parts over which the function loops will be empty, and so the regex match `m` will be `None`. To prevent an `AttributeError` from being thrown when `group` is called on `None` we check for it and continue.
giovannipizzi
approved these changes
Nov 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes #2185
If a formula contains leading or trailing whitespace, one of the parts over
which the function loops will be empty, and so the regex match
mwill beNone. To prevent anAttributeErrorfrom being thrown whengroupiscalled on
Nonewe check for it and continue.