Skip to content

Add temporary support for loading of new process node ORM classes#2188

Merged
giovannipizzi merged 1 commit into
aiidateam:provenance_redesignfrom
sphuber:fix_2187_temporary_load_support_node_process
Nov 12, 2018
Merged

Add temporary support for loading of new process node ORM classes#2188
giovannipizzi merged 1 commit into
aiidateam:provenance_redesignfrom
sphuber:fix_2187_temporary_load_support_node_process

Conversation

@sphuber
Copy link
Copy Markdown
Contributor

@sphuber sphuber commented Nov 12, 2018

Fixes #2187

The loading of the correct ORM class for a given entry in the DbNode table
is based on the type column, but its interpretation is still in a half-way
state. The plugin loader will first attempt to reverse engineer it into an entry
point and if that works load the correspondingly class. If that fails, it is
interpreted as an internal class and will attempt to load it directly as a module
path.

Adding the new process node ORM classes, will need to be supported by the plugin
loader, so here we add their entry points. We do this in the aiida:node group
but note that in the future the entire system will be changed to solely rely on
entry points, at which the format of the type column can be changed to be a
fully qualified entry point string, just as the process_type column already is.

The loading of the correct ORM class for a given entry in the `DbNode` table
is based on the `type` column, but its interpretation is still in a half-way
state. The plugin loader will first attempt to reverse engineer it into an entry
point and if that works load the correspondingly class. If that fails, it is
interpreted as an internal class and will attempt to load it directly as a module
path.

Adding the new process node ORM classes, will need to be supported by the plugin
loader, so here we add their entry points. We do this in the `aiida:node` group
but note that in the future the entire system will be changed to solely rely on
entry points, at which the format of the `type` column can be changed to be a
fully qualified entry point string, just as the `process_type` column already is.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.7%) to 67.255% when pulling 2f683d6 on sphuber:fix_2187_temporary_load_support_node_process into 9ad164e on aiidateam:provenance_redesign.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.7%) to 67.255% when pulling 2f683d6 on sphuber:fix_2187_temporary_load_support_node_process into 9ad164e on aiidateam:provenance_redesign.

@giovannipizzi giovannipizzi merged commit 13c57b9 into aiidateam:provenance_redesign Nov 12, 2018
@sphuber sphuber deleted the fix_2187_temporary_load_support_node_process branch November 12, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants