Add temporary support for loading of new process node ORM classes#2188
Merged
giovannipizzi merged 1 commit intoNov 12, 2018
Conversation
The loading of the correct ORM class for a given entry in the `DbNode` table is based on the `type` column, but its interpretation is still in a half-way state. The plugin loader will first attempt to reverse engineer it into an entry point and if that works load the correspondingly class. If that fails, it is interpreted as an internal class and will attempt to load it directly as a module path. Adding the new process node ORM classes, will need to be supported by the plugin loader, so here we add their entry points. We do this in the `aiida:node` group but note that in the future the entire system will be changed to solely rely on entry points, at which the format of the `type` column can be changed to be a fully qualified entry point string, just as the `process_type` column already is.
1 similar comment
giovannipizzi
approved these changes
Nov 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2187
The loading of the correct ORM class for a given entry in the
DbNodetableis based on the
typecolumn, but its interpretation is still in a half-waystate. The plugin loader will first attempt to reverse engineer it into an entry
point and if that works load the correspondingly class. If that fails, it is
interpreted as an internal class and will attempt to load it directly as a module
path.
Adding the new process node ORM classes, will need to be supported by the plugin
loader, so here we add their entry points. We do this in the
aiida:nodegroupbut note that in the future the entire system will be changed to solely rely on
entry points, at which the format of the
typecolumn can be changed to be afully qualified entry point string, just as the
process_typecolumn already is.