Return correct ORM AuthInfo class for JobCalculation._get_authinfo#2235
Merged
muhrin merged 1 commit intoNov 22, 2018
Merged
Conversation
The method returned the backend AuthInfo class, which does not have
the `get_transport` method that would be called for example in the
`_get_transport` method of the `JobCalculation` class. The fix is
to wrap the backend entity in the ORM class by calling
`AuthInfo.from_backend_entity`
Added two regression tests for this bug.
muhrin
approved these changes
Nov 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2234
The method returned the backend AuthInfo class, which does not have
the
get_transportmethod that would be called for example in the_get_transportmethod of theJobCalculationclass. The fix isto wrap the backend entity in the ORM class by calling
Added two regression tests for this bug.