Skip to content

Fix 2181 node incoming outgoing#2236

Merged
sphuber merged 14 commits into
aiidateam:provenance_redesignfrom
waychal:fix_2181_node_incoming_outgoing
Nov 22, 2018
Merged

Fix 2181 node incoming outgoing#2236
sphuber merged 14 commits into
aiidateam:provenance_redesignfrom
waychal:fix_2181_node_incoming_outgoing

Conversation

@waychal
Copy link
Copy Markdown
Contributor

@waychal waychal commented Nov 22, 2018

Fixes #2181

Two new methods are implemented:

  • get_incoming(): to get all input nodes of the given node
  • get_outgoing(): to get all output nodes of the given node

Deprecated:

  • get_inputs()
  • get_inputs_dict()
  • get_outputs()
  • get_outputs_dict()

Also all the occurrences of get_inputs() and get_inputs_dict() are replaced by get_incoming() method and for get_outputs() and get_outputs_dict() by get_outgoing().

@waychal waychal requested a review from sphuber November 22, 2018 16:27
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 68.966% when pulling 3d18a15 on waychal:fix_2181_node_incoming_outgoing into 9501779 on aiidateam:provenance_redesign.

Copy link
Copy Markdown
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @waychal

@sphuber sphuber merged commit f2ee588 into aiidateam:provenance_redesign Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants