Make verdi callable as sub command#2240
Merged
Merged
Conversation
Because the `verdi` group was not marked as callable without subcommand, the `--version` option was broken as it would throw a `Missing command` error. Adding `invoke_without_command=True` to the `verdi` group declaration and making the `--version` an eager option will ensure it works without specifying a sub command. A test has been added to test this functionality.
sphuber
force-pushed
the
fix_2239_verdi_version
branch
from
814f75b to
d6ea517
Compare
sphuber
changed the title
verdi can be called as commandverdi callable as sub command
giovannipizzi
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2239
Because the
verdigroup was not marked as callable withoutsubcommand, the
--versionoption was broken as it would throwa
Missing commanderror. Addinginvoke_without_command=Truetothe
verdigroup declaration and making the--versionan eageroption will ensure it works without specifying a sub command.
A test has been added to test this functionality.