Allow existing profile to be overriden in verdi setup#2244
Merged
sphuber merged 1 commit intoNov 27, 2018
Merged
Conversation
|
Coverage decreased (-0.007%) to 68.081% when pulling 57c5f023e37671bc9932b2e42a1492d1fad8c50d on sphuber:fix_2243_verdi_setup_non_interactive_override into 446ce15 on aiidateam:develop. |
Member
|
What about adding a test for the new option? |
sphuber
force-pushed
the
fix_2243_verdi_setup_non_interactive_override
branch
from
57c5f02 to
008a9fe
Compare
With the `--force` flag a user can suppress the exception that is raised when one tries to create an existing profile in non-interactive mode. With the flag the existing profile will be overriden with the specified values except for the profile UUID which will be kept the same as it is auto generate and can also not be specified by the user on the command line.
sphuber
force-pushed
the
fix_2243_verdi_setup_non_interactive_override
branch
from
008a9fe to
1ea6e18
Compare
Contributor
Author
|
Didn't add a test at first, because there weren't any tests for |
Member
Yikes! Thanks a lot for taking the time to resolve this! |
ltalirz
approved these changes
Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2243
With the
--forceflag a user can suppress the exception that is raisedwhen one tries to create an existing profile in non-interactive mode. With
the flag the existing profile will be overridden with the specified values
except for the profile UUID which will be kept the same as it is auto
generate and can also not be specified by the user on the command line.