Put in an explicit check raising when calculations call another process#2250
Merged
giovannipizzi merged 1 commit intoNov 29, 2018
Conversation
By definition, calculation type processes cannot call other processes. This was already indirectly guarded against by the link validation process. If one attempted to add a `CALL` link from a `CalulationNode`, the link validation would raise a `ValueError`. However, it is more instructive for the user to catch this problem before attempting to add the link. Therefore, when setting up the database record for a process, if a parent process is available, we ensure that it is not a calculation type process, or we raise an `InvalidOperation` exception. A test is added for a `calcfunction` calling another `calcfunction`.
giovannipizzi
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2248
By definition, calculation type processes cannot call other processes.
This was already indirectly guarded against by the link validation
process. If one attempted to add a
CALLlink from aCalulationNode,the link validation would raise a
ValueError. However, it is moreinstructive for the user to catch this problem before attempting to add
the link. Therefore, when setting up the database record for a process,
if a parent process is available, we ensure that it is not a calculation
type process, or we raise an
InvalidOperationexception. A test isadded for a
calcfunctioncalling anothercalcfunction.