Skip to content

Changed type of uuids returned by the QueryBuilder to be unicode#2259

Merged
sphuber merged 7 commits into
aiidateam:provenance_redesignfrom
lekah:fix_node_uuid_231
Dec 3, 2018
Merged

Changed type of uuids returned by the QueryBuilder to be unicode#2259
sphuber merged 7 commits into
aiidateam:provenance_redesignfrom
lekah:fix_node_uuid_231

Conversation

@lekah
Copy link
Copy Markdown

@lekah lekah commented Dec 3, 2018

Fixes #231 and fixes #1862

@lekah lekah requested a review from sphuber December 3, 2018 13:10
Comment thread aiida/backends/tests/nodes.py Outdated

class TestTypes(AiidaTestCase):
"""
Test the transitive closure functionality
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong docstring

Comment thread aiida/backends/tests/nodes.py Outdated
delete_nodes([called.pk], verbosity=2, force=True, follow_returns=True)

self._check_existence(uuids_check_existence, uuids_check_deleted)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spurious newlines

from datetime import datetime
from json import loads as json_loads
import six
import six, uuid
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional space

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.009%) to 69.026% when pulling 12483ee on lekah:fix_node_uuid_231 into 0cce69f on aiidateam:provenance_redesign.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 3, 2018

Coverage Status

Coverage decreased (-0.04%) to 68.987% when pulling 7b58826 on lekah:fix_node_uuid_231 into 8293da3 on aiidateam:provenance_redesign.

@lekah lekah changed the title This resolves #231, by changing the type of uuid to strings before re… Changed type of uuids returned by the QueryBuilder to be unicode Dec 3, 2018
@sphuber sphuber merged commit df42835 into aiidateam:provenance_redesign Dec 3, 2018
@lekah lekah deleted the fix_node_uuid_231 branch December 4, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants