Skip to content

Raise exception when exporting a node without path sub folder in repository#2274

Merged
sphuber merged 4 commits into
aiidateam:provenance_redesignfrom
yakutovicha:provenance_redesign
Dec 4, 2018
Merged

Raise exception when exporting a node without path sub folder in repository#2274
sphuber merged 4 commits into
aiidateam:provenance_redesignfrom
yakutovicha:provenance_redesign

Conversation

@yakutovicha
Copy link
Copy Markdown
Contributor

@yakutovicha yakutovicha commented Dec 3, 2018

Fixes #2247

Raise an exception when exporting a node which does not contain
a 'path' folder in the file repository.

Raise an exception when exporting a node which does not contain
a 'path' folder in the file repository.
@yakutovicha yakutovicha requested a review from sphuber December 3, 2018 16:54
@yakutovicha yakutovicha changed the title Fix issue #2247 Raise exception when exporting a node without path sub folder in repository Dec 3, 2018
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 3, 2018

Coverage Status

Coverage decreased (-6.8%) to 62.169% when pulling d859a67 on yakutovicha:provenance_redesign into 6c6b890 on aiidateam:provenance_redesign.

Comment thread aiida/orm/importexport.py Outdated
Comment thread aiida/orm/importexport.py Outdated
* use os.path.join to join the two parts and use the
Node._path_subfolder_name attribute to get the name of the sub
path instead of hard coding it

* Modify exception message
@sphuber sphuber merged commit da6acac into aiidateam:provenance_redesign Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants