Change 'ancestor_of'/'descendant_of' to 'with_descendants'/'with_ancestors'#2278
Conversation
giovannipizzi
left a comment
giovannipizzi
left a comment
There was a problem hiding this comment.
I've got a couple of comments/questions
There was a problem hiding this comment.
If the user uses the old 'descendant_of', will this still work? Maybe we should keep all four options for now?
There was a problem hiding this comment.
Yes, well spotted. Put these back in.
There was a problem hiding this comment.
Is this _beta version still implemented? Probably @lekah can answer this
There was a problem hiding this comment.
No, what we're doing now (transitive closure on the fly) used to be called _beta. This string passed is just for the exception, and can be changed without a problem (i.e. remove _beta in the string).
My suggest: without a new issue within this pull request, if noone objects.
There was a problem hiding this comment.
Made these changes.
- Deprecate ancestor_of and descendant_of - Replace all occurances of ancestor_of with with_descendants - Replace all occurances of descendant_of with with_ancestors - Update docs with this convention
- Remove _beta versions of ancestor_of and descendant_of joins - Add ancestor_of and descendant_of back in to check for valid join keywords.
ConradJohnston
force-pushed
the
fix_2209_replace_ancestor_of
branch
from
ca412b7 to
8758769
Compare
5 participants
Fixes #2209 .
Deprecates the Querybuilder 'ancestor_of'/'descendant of' join type specifications and replaces them with 'with_descendants'/'with_ancestors' respectively. All deprecated uses are updated and the docs changed to reflect this new convention.