Skip test for unicode folder names if file system encoding is not set to unicode#2283
Merged
Merged
Conversation
Skip test for unicode folder names if the filesystem encoding is not set to UTF-8
Member
Contributor
|
Yes, I hot fixed this in PR #2290 |
sphuber
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294
Since all tests run as intended even tough file system encoding is not necessarily set to unicode (ran tests for locales
de_DE.UTF-8andde_DE.iso88591) it should be safe to just skip this test if the file system encoding differs from unicode.