Ensure correct types of LinkTriples returned by Node.get_stored_link_triples#2292
Merged
giovannipizzi merged 1 commit intoDec 5, 2018
Conversation
sphuber
force-pushed
the
fix_2291_get_stored_link_triples_type
branch
from
5e888ec to
f8a3149
Compare
…nk_triples` The `Node.get_stored_link_triples` was using `LinkTriple` instances where the type of the `link_type` element was not of `LinkType` but of string, as it was directly using the string value returned by the query builder for the `type` column of the `DbLink` table. By wrapping this value in `LinkType` the returned `LinkTriples` once again have the correct type for all its elements.
sphuber
force-pushed
the
fix_2291_get_stored_link_triples_type
branch
from
f8a3149 to
d7c99b0
Compare
giovannipizzi
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2291
The
Node.get_stored_link_tripleswas usingLinkTripleinstances where thetype of the
link_typeelement was not ofLinkTypebut of string, as it wasdirectly using the string value returned by the query builder for the
typecolumn of the
DbLinktable. By wrapping this value inLinkTypethe returnedLinkTriplesonce again have the correct type for all its elements.