Move requirements from setup_requirements.py to setup.json#2307
Merged
sphuber merged 10 commits intoDec 6, 2018
Merged
Conversation
see discussion in aiidateam#2241
* move fastentrypoints.py to utils folder
Member
Author
|
still one thing to fix, will reopen in a bit |
Member
Author
|
done |
sphuber
requested changes
Dec 6, 2018
| include docs/source/images/*.png | ||
| include fastentrypoints.py | ||
| include setup_requirements.py | ||
| include utils/* |
Contributor
There was a problem hiding this comment.
Don't all python files get automatically included? The utils folder only has python files so it should be good no? Or is this necessary because it is outside the aiida package folder?
| SETUP_JSON = json.load(info) | ||
|
|
||
| SETUP_JSON['extras_require'][ | ||
| 'testing'] += SETUP_JSON['extras_require']['rest'] \ |
Contributor
There was a problem hiding this comment.
weird position of 'testing' key on new line
| from __future__ import absolute_import | ||
| import click | ||
| import os | ||
| from os import path |
Contributor
There was a problem hiding this comment.
Is there a problem with using os.path, since we already import os anyway?
| sys.exit(1) | ||
|
|
||
| # Overwrite version in setup.json | ||
| #setup_content['version'] = VERSION |
* automatic update of version number * path => os.path
sphuber
approved these changes
Dec 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2241
This moves all dependency information from the
setup_requirements.pypython file to asetup.json.This will allow us to implement automatic checks on collisions of entry points
setup.json(necessary to keep it there for the registration in the registry)
.pylintrc. the only blacklist is now in.pre-commit-config.yamlsetup.pyfrom blacklistdev_spinxextextra (contained only pytest, made part oftesting)