Various speedups for verdi cmdline#2315
Merged
sphuber merged 7 commits intoDec 7, 2018
Merged
Conversation
In particular when completing tests. Thanks to @ltalirz This fixes aiidateam#376 (again...). Fixes include: - using a new instance of the reentry manager that prevents automatic reentry scans - removed unuseful with_dbenv decorators from 'verdi devel tests' and from the TestModuleParamType of click - prevent unnecessary imports of plumpy that is a bit slow to import Also, we fixed the place where AIIDADB_PROFILE is set in the main `verdi` click command, to set it also when a default profile is used (this was probably the reason of the unneeded with_dbenv calls)
Member
Author
|
Note: the time went down from to |
The plugin manager is now always using the same global reentry manager (that does NOT automatically re-run `reentry scan`).
Now if one runs ``` verdi -p aaa setup bbb ``` `aaa` is ignored and a profile `bbb` is used. Moreover, a default profile is set (if none is set yet) also when running non-interactively (that is what quicksetup does). This fixes aiidateam#2261
Completes the fix of aiidateam#2261
2 tasks
(and does not impact performance for TAB-completion)
Member
Author
|
Tests pass now @ltalirz |
ltalirz
previously approved these changes
Dec 7, 2018
Member
ltalirz
left a comment
ltalirz
left a comment
There was a problem hiding this comment.
I am Leopold Talirz and I approve this PR.
Moreover, small fixes to the .gitignore
ltalirz
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #376 and fixes #2261
In particular when completing tests.
Thanks to @ltalirz
This fixes #376 (again...).
Fixes include:
automatic reentry scans
from the TestModuleParamType of click
Also, we fixed the place where AIIDADB_PROFILE is set in the
main
verdiclick command, to set it also when a defaultprofile is used (this was probably the reason of the unneeded
with_dbenv calls)