Skip to content

Ensure QueryBuilder return frontend entity of DbLog and DbComment#2325

Merged
sphuber merged 1 commit into
aiidateam:provenance_redesignfrom
muhrin:fix_2321_db_log_orm_conversion
Dec 8, 2018
Merged

Ensure QueryBuilder return frontend entity of DbLog and DbComment#2325
sphuber merged 1 commit into
aiidateam:provenance_redesignfrom
muhrin:fix_2321_db_log_orm_conversion

Conversation

@muhrin
Copy link
Copy Markdown
Contributor

@muhrin muhrin commented Dec 7, 2018

Fixes #2321

@muhrin muhrin requested a review from szoupanos December 7, 2018 15:34
@muhrin muhrin changed the title Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder [BLOCKED] Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder Dec 7, 2018
Also moved a couple of modules to be plurals, namely `logs` and `comments`
@sphuber sphuber force-pushed the fix_2321_db_log_orm_conversion branch from dd5193c to e61dca7 Compare December 8, 2018 11:35
@sphuber sphuber changed the title [BLOCKED] Fixes #2321 DbLog and DbComment not being converted to ORM by QueryBuilder Ensure QueryBuilder return frontend entity of DbLog and DbComment Dec 8, 2018
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 68.962% when pulling e61dca7 on muhrin:fix_2321_db_log_orm_conversion into ada95a1 on aiidateam:provenance_redesign.

Copy link
Copy Markdown
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An absolute blinder

@sphuber sphuber merged commit a64d5c1 into aiidateam:provenance_redesign Dec 8, 2018
@muhrin muhrin deleted the fix_2321_db_log_orm_conversion branch December 12, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants