Skip to content

Docs reorganization - step 2 (installation section)#2330

Merged
sphuber merged 6 commits into
aiidateam:provenance_redesignfrom
ltalirz:docs-reorganize-install
Dec 12, 2018
Merged

Docs reorganization - step 2 (installation section)#2330
sphuber merged 6 commits into
aiidateam:provenance_redesignfrom
ltalirz:docs-reorganize-install

Conversation

@ltalirz
Copy link
Copy Markdown
Member

@ltalirz ltalirz commented Dec 9, 2018

This is my go at reorganizing the installation section of the docs to make it more intuitive and efficient to use.

  • quick install now contains all necessary information to actually set up AiiDA
  • foldable sections with instructions for different operating systems keep quick install page short
  • detailed instructions for different OS's retained under "prerequisites" section and linked directly from quick install
  • OS-specific sections on postgres and rabbitmq merged into corresponding "prerequisites" sections

Note: I added the provenance_redesign branch to RTD, i.e. you'll be able to inspect the docs there (after the PR is merged).

 * add OS instructions using foldable sections
 * quicksetup now actually contains all information required
@ltalirz ltalirz requested a review from sphuber December 9, 2018 20:51
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 9, 2018

Coverage Status

Coverage increased (+0.03%) to 68.103% when pulling a43a0f6 on ltalirz:docs-reorganize-install into c87a0db on aiidateam:provenance_redesign.

Copy link
Copy Markdown
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ltalirz , I really like the new structure. All good as far as I am concerned. I have just a few minor comments/typos. I realize that a few comments are not directly on things you changed, but I still think it would be good to fix them in this PR if possible

Comment thread docs/source/install/installation.rst Outdated
Comment thread docs/source/install/installation.rst Outdated
Comment thread docs/source/install/installation.rst Outdated
Comment thread docs/source/install/installation.rst Outdated
The first thing that will be asked to you is the timezone, extremely important to get correct dates and times for your calculations.
The first thing that will be asked to you is the timezone, important to get correct dates and times for your calculations.

AiiDA will do its best to try and understand the local timezone (if properly configured on your machine), and will suggest a set of sensible values.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true? Is it still prompting for the timezone?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the section below about a single default user as the daemon runner, is outdated. Each profile has its own daemon. Also, below that, there is an example output of the prompts during the setup, which is outdated. Could you update that please?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will simply delete this note.
@waychal Is the aiida password currently used in the REST API?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, the output of verdi setup is also outdated but interactive verdi setup anyhow needs to be fixed (#1483). After this, the output in the docs can be updated.

Comment thread docs/source/install/updating_installation.rst
.. _0.6.* SqlAlchemy: http://aiida-core.readthedocs.io/en/v0.7.0/installation.html#updating-from-0-6-0-django-to-0-7-0-sqlalchemy
.. _0.5.* Django: http://aiida-core.readthedocs.io/en/v0.7.0/installation.html#updating-from-0-5-0-to-0-6-0
.. _0.4.* Django: http://aiida-core.readthedocs.io/en/v0.5.0/installation.html#updating-from-0-4-1-to-0-5-0 No newline at end of file
.. _0.4.* Django: http://aiida-core.readthedocs.io/en/v0.5.0/installation.html#updating-from-0-4-1-to-0-5-0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the first paragraph in updating for aiida developers to tell them to use verdi --version to get the current version number, instead of going into a shell.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, and I will generally merge the "for developers" section with the regular upgrade instructions.
Is the sentence " Each version increase may come with its own necessary migrations and you should only ever update the version by one at a time." actually true?
It should be fine to skip aiida versions, right?

@sphuber sphuber merged commit 11e6988 into aiidateam:provenance_redesign Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants