Update export schema version and temporarily disable export#2341
Conversation
There was a problem hiding this comment.
Ehm... won't issue #2340 be closed when merging this PR?
I am confused...
There was a problem hiding this comment.
By the way: fine to be so explicit about it but I was under the impression that provenance_redesign was anyhow not meant to be used for any kind of production runs.
There was a problem hiding this comment.
You are absolutely right, it should reference #2342
Regarding the disabling of the export. It is true that provenance_design is not expected to work, however, we want to merge it soon and it is not clear if #2342 will then have already been addressed. To prevent incorrect archives from being accidentally created, I think it is better to disable it. Still we should fix it as soon as possible of course
There was a problem hiding this comment.
I have corrected the issue number reference. But I noticed that I forgot to skip tests that either rely on verdi export create or on fixture archives that are still v0.3. Not ideal, but I think it is still better than people accidentally creating broken archives
The migration after the provenance redesign has been merged into `provenance_redesign`. To avoid people from importing "dirty" export files into a cleanly migrated database, the export schema version is upped. Additionally, creating new export archives with the latest version is disabled, until the export procedure has been verified to abide by the new rules in place after the provenance redesign.
sphuber
force-pushed
the
fix_2340_disable_export_and_up_schema_version
branch
from
fae638c to
17a96c3
Compare
|
@giovannipizzi Can you please check and approve? |
4 participants
Fixes #2340
The migration after the provenance redesign has been merged into
provenance_redesign. To avoid people from importing "dirty" exportfiles into a cleanly migrated database, the export schema version is
upped. Additionally, creating new export archives with the latest
version is disabled, until the export procedure has been verified to
abide by the new rules in place after the provenance redesign.