Reorganised some SQL related commands#2346
Merged
sphuber merged 2 commits intoDec 13, 2018
Merged
Conversation
|
Coverage decreased (-6.9%) to 61.277% when pulling b7d734bab5d1c8a1799b8b79febfe2cc7fea4c98 on muhrin:reorganise_backend_sql_specific into 7ff016d on aiidateam:provenance_redesign. |
muhrin
changed the title
Moved from QueryManager to the corresponding backend classes. The longer term view will probably be that QueryManager gets dropped completely and more backend specific methods will be moved into the Backend class itself. This way we have a single point where we know to find such methods.
muhrin
force-pushed
the
reorganise_backend_sql_specific
branch
from
b7d734b to
c6b9473
Compare
muhrin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved from QueryManager to the corresponding backend classes. The
longer term view will probably be that QueryManager gets dropped
completely and more backend specific methods will be moved into the
Backend class itself. This way we have a single point where we know to
find such methods.