Replace call to deprecated set_ methods with set_option #2361
Conversation
4e20472 to
5ee4864
Compare
set_ methods with set_option set_ methods with set_option
6486c04 to
232ad54
Compare
232ad54 to
fd975ac
Compare
|
Funny, though, that we need to do special treatment for |
|
Yes, I wasn't quite sure about this solution, so let's not merge this quite yet and discuss. The problem is if I remember correctly that |
|
@giovannipizzi I have looked again in more depth into why we need an exception for If you agree as well, I think this is ready to merge |
b647e39 to
cff9db9
Compare
The `Node._set_internal` method was still calling deprecated `set_` methods for options of the `CalcJobNode` sub class. These should now be set through the explicit `set_option` method. The `JobProcess` was likewise violating this rule, when setting the options of the underlying `CalcJobNode` it is using as a storage record.
cff9db9 to
dccc05b
Compare
Fixes #2360
The
Node._set_internalmethod was still calling deprecatedset_methods for options of the
CalcJobNodesub class. These should nowbe set through the explicit
set_optionmethod. TheJobProcesswas likewise violating this rule, when setting the options of the
underlying
CalcJobNodeit is using as a storage record.