Merge develop into provenance_redesign and update pre-commit dependencies#2365
Merged
sphuber merged 12 commits intoJan 4, 2019
Merged
Conversation
"The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources." [1] https://pypi.org/project/psycopg2-binary/
psycopg2-binary 2.7.4 => psycopg2 2.7.6
…dateam#2218) Thanks @borellim! Note: I'm merging this directly into develop (and not provenance_redesign) because it's an important bug fix and shouldn't create merge conflicts. (@sphuber)
…iidateam#2235) The method returned the backend AuthInfo class, which does not have the `get_transport` method that would be called for example in the `_get_transport` method of the `JobCalculation` class. The fix is to wrap the backend entity in the ORM class by calling `AuthInfo.from_backend_entity` Added two regression tests for this bug.
Because the `verdi` group was not marked as callable without subcommand, the `--version` option was broken as it would throw a `Missing command` error. Adding `invoke_without_command=True` to the `verdi` group declaration and making the `--version` an eager option will ensure it works without specifying a sub command. A test has been added to test this functionality.
) With the `--force` flag a user can suppress the exception that is raised when one tries to create an existing profile in non-interactive mode. With the flag the existing profile will be overridden with the specified values except for the profile UUID which will be kept the same as it is auto generate and can also not be specified by the user on the command line.
…ateam#2252) The implementation was using the backend collection to `get` a given computer for the remote copy lists, but this method is not defined. Instead this operation should go through the front end collection.
This prevents a mismatch between for example `numpy` and `scipy`.
The requirement `prospector` already indirectly requires `pylint` and it needs a different version based on the version of python. By fixing the version of `pylint` ourselves, we will have the wrong version for the version of `prospector` for either one of python 2 or python 3.
Starting from `pylint-django>=2.0` only `pylint>=2.0` is supported which has dropped support for python 2. As a result we need to depend on different version of `pylint-django` based on the version of python. With the new version of `pylint` a lot of new checks are added that had to be either corrected or disabled. Given that some of these checks only are valid for `pylint>=2.0`, they will trigger a warning in the pre-commit for python 2. For this reason we have to temporarily disable the `bad-option-value` globally in the `.pylintrc`. When support for python 2 is dropped, this should be removed.
ltalirz
reviewed
Jan 4, 2019
|
|
||
| def reverse_code(apps, schema_editor): | ||
| """Reversing the inference of the process type is not possible and not necessary.""" | ||
| pass |
Contributor
Author
There was a problem hiding this comment.
Because it is not necessary if there is a docstring
ltalirz
approved these changes
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original plan was to just merge
developintoprovenance_redesignsince it contains some crucial bug fixes. However, tests stopped passing due to various issues with incompatible version of pre-commit tools and python versions. I added these changes on top of the merge commit and fixed a whole slew of new linter warnings that came as a result of upgradingpylintto version 2.0 which only supports python 3.