Add functionality to delete individual Log entries to collection#2369
Merged
sphuber merged 1 commit intoJan 8, 2019
Merged
Conversation
sphuber
force-pushed
the
fix_2368_orm_delete_single_log
branch
from
1bfeaf4 to
6b876a5
Compare
giovannipizzi
approved these changes
Jan 8, 2019
Also fixed a bug in the `delete` method of the `AuthInfo` and `Comment` collections that were not caught because there were no tests. If the entry that was asked to be deleted did not exist, no exception was raised, however, that was expected by the implementation.
sphuber
force-pushed
the
fix_2368_orm_delete_single_log
branch
from
6b876a5 to
a12e356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2368
Also fixed a bug in the
deletemethod of theAuthInfoandCommentcollections that were not caught because there were no tests. If the
entry that was asked to be deleted did not exist, no exception was
raised, however, that was expected by the implementation.