Move aiida.orm.data within the aiida.orm.node module#2402
Conversation
68cc805 to
43ba8a9
Compare
aiida.orm.data within the aiida.orm.node moduleaiida.orm.data within the aiida.orm.node module
|
@giovannipizzi this PR is good for review. I added the suggestion you made in #2401 to add a message to the FInally, the test at Jenkins is failing because of the bug we had before. I already opened this PR before #2401 was closed, so now I had to rebase this, but that leads to merging conflicts on the Jenkins server, because it does not automatically do a hard reset. If you can access the machine, you can run |
|
Mmm, I think the SQL is wrong ( |
giovannipizzi
left a comment
There was a problem hiding this comment.
At least the SQL needs to be adapted (see my comment above), I didn't do a full review yet.
f077e0c to
24823d0
Compare
There was a problem hiding this comment.
A comment: while technically the regex alone would be not fully correct (it should be '^data\\.' I think, as . matches any character) it's ok because the following WHERE clause does the right filter
24823d0 to
28abc6a
Compare
This final move makes the hierarchy of all node modules and its sub classes consistent. The `Data` and `ProcessNode` classes who are both sub classes of the `Node` base class and are direct siblings live on the same level in the hierarchy, direct within the `aiida.orm.node` module. Note that because the type string of all `Data` nodes now will start with `node.` instead of `data.`, a data migration had to be added.
28abc6a to
c4bd515
Compare
Fixes #2200
This final move makes the hierarchy of all node modules and its sub
classes consistent. The
DataandProcessNodeclasses who are bothsub classes of the
Nodebase class and are direct siblings live on thesame level in the hierarchy, direct within the
aiida.orm.nodemodule.Note that because the type string of all
Datanodes now will startwith
node.instead ofdata., a data migration had to be added.