Add exception for calculation.job.JobCalculation process type inference#2428
Merged
sphuber merged 1 commit intoFeb 8, 2019
Conversation
|
Coverage increased (+0.02%) to 69.628% when pulling 074403c5caa188eee1d458ba9308dfd15eb25d97 on sphuber:fix_2406_provenance_redesign_migration into ff7af8c on aiidateam:provenance_redesign. |
2 similar comments
|
Coverage increased (+0.02%) to 69.628% when pulling 074403c5caa188eee1d458ba9308dfd15eb25d97 on sphuber:fix_2406_provenance_redesign_migration into ff7af8c on aiidateam:provenance_redesign. |
|
Coverage increased (+0.02%) to 69.628% when pulling 074403c5caa188eee1d458ba9308dfd15eb25d97 on sphuber:fix_2406_provenance_redesign_migration into ff7af8c on aiidateam:provenance_redesign. |
…ence In the migration following the provenance redesign, the process type had to be inferred from the existing type string for `JobCalculation` nodes. The function `infer_calculation_entry_point` did not account for literal `calculation.job.JobCalculation.` type strings being present and would return `.JobCalculation` as the fallback process type. However, it makes more sense to just have an empty process type string in this case, as would be the case for a base `CalcJobNode` instance.
sphuber
force-pushed
the
fix_2406_provenance_redesign_migration
branch
from
074403c to
01c6a8c
Compare
giovannipizzi
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2406
In the migration following the provenance redesign, the process type had
to be inferred from the existing type string for
JobCalculationnodes.The function
infer_calculation_entry_pointdid not account for literalcalculation.job.JobCalculation.type strings being present and wouldreturn
.JobCalculationas the fallback process type. However, it makesmore sense to just have an empty process type string in this case, as
would be the case for a base
CalcJobNodeinstance.