Skip to content

Fix description of 'contains' filter in QB docs#2429

Merged
sphuber merged 2 commits into
provenance_redesignfrom
query-contains-filter-doc
Feb 8, 2019
Merged

Fix description of 'contains' filter in QB docs#2429
sphuber merged 2 commits into
provenance_redesignfrom
query-contains-filter-doc

Conversation

@borellim
Copy link
Copy Markdown
Member

The 'contains' filter operator in the QueryBuilder takes a list of values, not an individual value.
This is confirmed by in-source documentation in aiida/orm/implementation/sqlalchemy/querybuilder.py.

The 'contains' filter operator in the QueryBuilder takes a list of
values, not an individual value.
@sphuber sphuber force-pushed the query-contains-filter-doc branch from 467ddd3 to 88e94bd Compare February 8, 2019 15:10
@sphuber sphuber changed the base branch from develop to provenance_redesign February 8, 2019 15:10
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-6.03%) to 63.629% when pulling 6b2790b on query-contains-filter-doc into 0c9e0b8 on provenance_redesign.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-6.03%) to 63.629% when pulling 6b2790b on query-contains-filter-doc into 0c9e0b8 on provenance_redesign.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 8, 2019

Coverage Status

Coverage increased (+0.04%) to 69.698% when pulling 6b2790b on query-contains-filter-doc into 0c9e0b8 on provenance_redesign.

@sphuber sphuber self-requested a review February 8, 2019 17:26
Copy link
Copy Markdown
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @borellim

@sphuber sphuber merged commit 7420655 into provenance_redesign Feb 8, 2019
@sphuber sphuber deleted the query-contains-filter-doc branch February 8, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants