Fix import error of md5_file in CifData and UpfData#2438
Merged
sphuber merged 2 commits intoFeb 8, 2019
Merged
Conversation
The recent move of `md5_file` from `aiida.common.utils` to `aiida.common.files` was not caught in some of the methods of these classes because it imported the whole module `aiida.common.utils` and used the function as `aiida.common.utils.md5_file`.
sphuber
force-pushed
the
fix_2437_import_errors_md5_file_in_upf_cif_data
branch
from
c39bece to
cb14d01
Compare
giovannipizzi
approved these changes
Feb 8, 2019
…le_in_upf_cif_data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2437
The recent move of
md5_filefromaiida.common.utilstoaiida.common.fileswas not caught in some of the methods of theseclasses because it imported the whole module
aiida.common.utilsandused the function as
aiida.common.utils.md5_file.