Catch UnroutableError for orphaned processes in verdi process calls#2445
Merged
sphuber merged 2 commits intoFeb 8, 2019
Merged
Conversation
If the RabbitMQ task of a running process is lost before it is completed, it will never complete, but any `verdi process` commands that try to reach it such as `pause`, `play` and `kill` will throw an `UnroutableError`. This exception should be caught and an error message should be printed instead.
sphuber
force-pushed
the
fix_2443_verdi_process_unroutables
branch
from
d2588c5 to
1baa58f
Compare
giovannipizzi
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2443
If the RabbitMQ task of a running process is lost before it is
completed, it will never complete, but any
verdi processcommands thattry to reach it such as
pause,playandkillwill throw anUnroutableError. This exception should be caught and an error messageshould be printed instead.