Skip to content

Add the verdi data upf content command#2468

Merged
sphuber merged 2 commits into
aiidateam:provenance_redesignfrom
sphuber:fix_2467_verdi_data_cif_content
Feb 9, 2019
Merged

Add the verdi data upf content command#2468
sphuber merged 2 commits into
aiidateam:provenance_redesignfrom
sphuber:fix_2467_verdi_data_cif_content

Conversation

@sphuber
Copy link
Copy Markdown
Contributor

@sphuber sphuber commented Feb 8, 2019

Fixes #2467

This will print the bare contents of the file behind CifData nodes

This will print the bare contents of the file behind `CifData` nodes
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 8, 2019

Coverage Status

Coverage decreased (-0.03%) to 69.678% when pulling a3b7f3d on sphuber:fix_2467_verdi_data_cif_content into 69dbdb2 on aiidateam:provenance_redesign.

Copy link
Copy Markdown
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, even if at some point we should start deprecating the methods returning a path and provide instead (in this case in the SinglefileData class) an open method

@sphuber sphuber merged commit 5c65039 into aiidateam:provenance_redesign Feb 9, 2019
@sphuber sphuber deleted the fix_2467_verdi_data_cif_content branch February 9, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants