Renaming DbNode.type to DbNode.node_type

[sphuber]

Fixed #2510

While we are at it....

[giovannipizzi]

So you did manage to do it!! :-)

[sphuber]

@giovannipizzi faster than I anticipated. I could start working on #2398 . Originally we discussed that it would not be critical, but seeing as we still have a week and I could get started on it now, might be worth it to do it before the beta release. What do you think?

Also the migrations here were dead easy. Are we sure we are not missing anything (not including the migration of export archives)?

[coveralls]

Coverage decreased (-0.09%) to 69.63% when pulling 2de803bcb142b1065faf3001d8b8154cc2ea5847 on sphuber:fix_2510_rename_node_type_to_node_type into f8c0191 on aiidateam:provenance_redesign.

[sphuber]

Uhm.... there is a reason it went so fast. I forgot to un-comment the migration tests 🤦‍♂️
but of course those are failing miserably.

[giovannipizzi]

I think the migrations are ok (we're getting too used to complex ones :-D )
Ok to proceed to #2398 (a bit more complex, requires again a migration), but then I suggest to prioritise stating cleaning up the wiki page for backward-incompatible things (I just reopened #2320)

[sphuber]

This might not actually be reasonably doable after all. Changing the DbNode model by changing the type column's name breaks all the migration tests. The actual database model can no longer be used anywhere, which therefore includes our backend and frontend classes. The only solution is to only use the apps to get the model at the time of the migration that is being tested. This is doable for quite a few tests and I have already migrated them to only use the django apps. But there are three TestCalcAttributeKeysMigration, TestDuplicateNodeUuidMigration and the TestTrajectoryDataMigration that use attributes, the repository and trajectory array setters and getters, that are not clear how to decouple from our ORM. At this point I am not sure whether the required effort would be worth it, even though I think the name change is important. Any ideas @giovannipizzi ?