Reorganize the aiida.work module#2524
Merged
sphuber merged 1 commit intoFeb 25, 2019
Merged
Conversation
|
Coverage increased (+0.005%) to 69.765% when pulling 93eb83b8ae0a18a7a9e249eca0266ab5282ca755 on sphuber:fix_2523_reorganize_aiida_work into 2e4ab93 on aiidateam:provenance_redesign. |
sphuber
force-pushed
the
fix_2523_reorganize_aiida_work
branch
2 times, most recently
from
0cf2af5 to
17ee5f1
Compare
The `aiida.work` module was conceived when the `WorkChain` class was first implemented. Ever since, the `Process` class on which it is based starting filling are more prominent role and slowly all running processes were migrated to be a `Process` sub class. All of the logic was added to the `aiida.work` module, which turned into the module that implemented all the functionality of the engine of `aiida-core`. Therefore we rename the `aiida.work` module to `aiida.engine` and reorganize the internal structure to clarify the role of the different components.
sphuber
force-pushed
the
fix_2523_reorganize_aiida_work
branch
from
17ee5f1 to
7dcaebe
Compare
giovannipizzi
approved these changes
Feb 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2523
The
aiida.workmodule was conceived when theWorkChainclass wasfirst implemented. Ever since, the
Processclass on which it is basedstarting filling are more prominent role and slowly all running
processes were migrated to be a
Processsub class. All of the logicwas added to the
aiida.workmodule, which turned into the module thatimplemented all the functionality of the engine of
aiida-core.Therefore we rename the
aiida.workmodule toaiida.engineandreorganize the internal structure to clarify the role of the different
components.