Remove the FrozenDict data sub class#2532
Merged
sphuber merged 1 commit intoFeb 26, 2019
Merged
Conversation
|
Coverage decreased (-0.05%) to 69.749% when pulling c43e4fee8175443494b0d3d4ed81e83b88df0fcb on sphuber:fix_2526_remove_frozen_dict_data_class into 562935c on aiidateam:provenance_redesign. |
giovannipizzi
approved these changes
Feb 25, 2019
The `FrozenDict` class was added to allow `ProcessNode` instances to be passed to `Process` classes. However, its implementation is flawed as it uses the pks of the nodes it wraps, which are not persistent across databases and as such provenance will be lost when it is imported. We remove the source code here. In a future commit, it will have to be decided how to migrate existing data.
sphuber
force-pushed
the
fix_2526_remove_frozen_dict_data_class
branch
from
c43e4fe to
97c5b30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2526
The
FrozenDictclass was added to allowProcessNodeinstances to bepassed to
Processclasses. However, its implementation is flawed as ituses the pks of the nodes it wraps, which are not persistent across
databases and as such provenance will be lost when it is imported. We
remove the source code here. In a future commit, it will have to be
decided how to migrate existing data.