test_url_query: Expand tests#220
Conversation
behnam
force-pushed
the
query_1
branch
2 times, most recently
from
4bf3c56 to
f3bd101
Compare
|
Looks like we have a conflict here: I think we should limit mypy to py>=36. Let me send a separate PR for that. |
|
Actually, disabling mypy wouldn't work, because it's a syntax error for normal executions on PY35. Instead, falling back to PY35-compatible type hint for the const value, and silencing #fingerscrossed |
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 4 4
Lines 768 768
Branches 217 217
=======================================
Hits 766 766
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@asvetlov, I believe this is ready for review. |
mjpieters
left a comment
mjpieters
left a comment
There was a problem hiding this comment.
LGTM, and the original change request has been addressed.
This comment was marked as outdated.
This comment was marked as outdated.
Expanding URL-query tests to cover more behaviors around special chars when parsing, setting, re-setting and getting values. Bug revealed are marked with `FIXME` to address separately.
Semi-colons are _not_ reserved characters in the query string of a URL; the query string portion consists of `pchar` characters, and `pchar` includes `sub-delim`, which is the class that contains `;`.
- There is no way to distinguish between `?a=` and `?a` when rebuilding a query string. - The further encoding of query delimiters (`=` and `&` in query _values_ is entirely normal and expected.
psf-chronographer
bot
added
the
bot:chronographer:provided
4 participants
Expanding URL-query tests to cover more behaviors around special chars
when parsing, setting, re-setting and getting values.
Bug revealed are marked with
FIXMEto address separately.