allow to update query string using mod operator#435
Merged
asvetlov merged 5 commits intoaio-libs:masterfrom Jul 19, 2020
Merged
allow to update query string using mod operator#435asvetlov merged 5 commits intoaio-libs:masterfrom
asvetlov merged 5 commits intoaio-libs:masterfrom
Conversation
f57d0eb to
376b330
Compare
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 99.24% 99.25% +0.01%
==========================================
Files 2 2
Lines 664 673 +9
Branches 152 154 +2
==========================================
+ Hits 659 668 +9
Misses 5 5
Continue to review full report at Codecov.
|
Member
that issue suggests |
webknjaz
reviewed
Apr 4, 2020
Member
webknjaz
left a comment
There was a problem hiding this comment.
I think the UX research part is missing here: #434 (comment)
Member
|
I like this PR and can buy it. Please make the following before the merge:
|
asvetlov
requested changes
Jul 18, 2020
Member
asvetlov
left a comment
There was a problem hiding this comment.
The steps above are required to make the PR done.
asvetlov
requested changes
Jul 18, 2020
Member
asvetlov
left a comment
There was a problem hiding this comment.
Looks good, please apply my comments.
asvetlov
reviewed
Jul 19, 2020
asvetlov
approved these changes
Jul 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
update query string using mod operator
Are there changes in behavior for the user?
Related issue number
close #434
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.